Updated to Rufus-Scheduler 3.0 syntax#237
Updated to Rufus-Scheduler 3.0 syntax#237xander-miller wants to merge 3 commits intoShopify:masterfrom
Conversation
xander-miller
commented
Oct 2, 2013
xander-miller
commented
- modified gemspec to require rufus-scheduler >= 3.0.0
- modified scheduler call to use .new instead of previous .start_new syntax
+ modified gemspec to require rufus-scheduler >= 3.0.0 + modified scheduler call to use .new instead of previous .start_new syntax
|
Oops! I just merged a fix to restrict the gem to version 2.x.x. Bad timing on my part. Please rebase this PR so that it merges cleanly and I'll get it in. |
+ modified gemspec to require rufus-scheduler >= 3.0.0 + modified scheduler call to use .new instead of previous .start_new syntax
|
K, I fixed it. I think, first time trying to update a fork to an upstream master. |
|
Doesn't work for me. As soon as I try to switch to 3.0.2 the jobs stop pushing data to the dashboard. Switching back to 2.0.24 solves the problem. Any thoughts? |
|
As @gordhawkins has pointed out, this change seems to be a breaking change and as such should wait for the next major release to be merged. The migration path is pretty clear though, simply replace .start_new with .new in all jobs. Perhaps the change is small enough to be merged? Thoughts? |
|
Hi. Just checking on the status of upgrading to rufus-scheduler 3.0? I'm not sure I follow the issue with |
5 participants
